Repository navigation
Updates for frame type deferral release code and lock file update - #706
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Zero-limit handling can stall output, unrelated swapchains can interrupt data propagation, and Visual Studio test registration is missing.
3 open findings
What changed in this PR
Updates frame-type deferral release handling in the trace consumer and refreshes the auxiliary test-data pin.
Changes:
- Releases waiting presents on later completions or timeout.
- Adds seven regression tests and CMake registration.
- Updates deferral documentation and pinned test data.
| File | Description |
|---|---|
| Tests/aux-data.lock.json | Updates the test-data commit. |
| PresentData/PresentMonTraceConsumer.hpp | Clarifies the waiting-state comment. |
| PresentData/PresentMonTraceConsumer.cpp | Revises release and propagation conditions. |
| IntelPresentMon/UnitTests/PresentFrameTypeDeferralTests.cpp | Adds deferral regression tests. |
| IntelPresentMon/UnitTests/CMakeLists.txt | Registers the new test source. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Replace the WaitingForFrameId reset added to the stale-deferral block in #702 with a deterministic release rule. That reset only ran when mReadyCount was 0, so it depended on how fast the output thread dequeued presents. This made ETL results vary between runs and could release a generated frame before its partner merged the propagated data. A present waiting for a PresentFrameType partner is now released when: - a later-started present from the same process completes, whether or not it has a PresentFrameType (e.g., frame generation was turned off), or - any present that started more than mDeferralTimeLimit later completes (e.g., the process stopped presenting). A limit of 0 releases on the next later-started present, matching the documented meaning of 0. An earlier-started present that completes late does not release a waiting present. Only a typed successor with the same FrameId takes the propagated data from an Intel_XEFG present. Add PresentFrameTypeDeferralTests to the CMake and Visual Studio unit test projects. Update the AuxData lock to the regenerated gold CSVs for test_case_7, 8, 9, 11 and 12 (default and _v2), which reflect the app timing pruning from #702 and the new release rule.
markgalvan-intel
force-pushed
the
fix/frame-type-deferral-release
branch
from
October 16, 2026 22:05
a1beba8 to
5035b72
Compare
DevTechProfile
added a commit
to DevTechProfile/CXPresentMon
that referenced
this pull request
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.