Skip to content

GPA is not library friendly #36

Open

Description

@chaoticbob

GPA usage of CMake is very awkward making it difficult to simply include GPA into an existing large project by setting variables and then calling add_subdirectory. Currently doing so causes the build process to produce binary paths that can't be found.

Activity

  1. chesik-amd commented on Mar 5, 2019

    @chesik-amd
    Contributor

    Yes, this isn't a usage model that we considered. We'll take a look to see what can be done to make this experience better.

  2. added a commit that references this issue on Mar 18, 2019
  3. chesik-amd commented on Mar 18, 2019

    @chesik-amd
    Contributor

    I've just pushed a few changes to the CMake files. WIth these changes, we've been able to include GPA in another project by simply using add_subdirectory. There is still a prerequisite that you'll need to run UpdateCommon.py before doing this. Can you give the latest sources a try and see if it works better for you? If you still run into problems, we may need more info on exactly how you are using this, and what exact problems you still see.

    Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions