Repository navigation
lv2, qualcost: a repeat lookup reads one manifest and lists no directory again - #359
Merged
Merged
Conversation
Contributor
Author
|
Pi 5, Zynthian vangelis, real LV2 world (1336 plugins), private dummy JACK server at 48000/256. Own LV2 adds through the daemon: a fresh daemon per run, four adds (the first, then three more), three runs, medians in ms. Installed 0.15.7 against this branch built on the Pi.
On 0.15.7 the later adds cost more than the first: from the second add the daemon also lists the qualification directory and parses the records. That is gone, and a plugin found late in the walk no longer pays the walk on each add. |
…ory again The daemon looks a plugin's bundle up on every add, up to three times, by walking the search path's manifests in directory order; on a Zynthian that is hundreds of manifests for a plugin found late. A bundle found holding the binary is remembered and checked again with its one manifest; a bundle that moved or no longer holds the plugin is looked for again, and a bundle that only names it is never remembered, so a binary installed later still wins. Its qualification records were found by listing the directory (thousands of files on a Zynthian) and parsed on every read. They are remembered with the directory's time and each file's time and size: a record replaced, rewritten in place or added is read as before. Red first: proc_test and qualcost_test counted the manifests read and the directory listings and parses of a repeat lookup, and failed on the walk.
linuxnow
force-pushed
the
perf/locate-cache
branch
from
November 1, 2026 02:23
3356710 to
f613f1f
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daemon's share of an own LV2 add on the Pi (job 11, add cut a). Strace of three own adds of ZamComp on the real world showed, per add:
Now a bundle that holds the plugin's binary is remembered and checked with its one manifest on each lookup. A bundle that moved or no longer holds the plugin is walked for again. A bundle that only names the plugin (a GUI bundle) is never remembered, so a binary installed later still wins. Records are remembered with the directory's time and each file's time and size.
Red first, locally in the worker image: test-proc failed 'found again with one manifest read' (1 failed), qualcost-test failed 'a repeat read lists and parses once' (1 of 14). Both are green with the change.
Sabotage, each guard broken alone:
Pi before/after numbers follow in a comment. Console gain: the console's daemon adds LV2 plugins through the same lookup, and its scene loads add many at once.