Repository navigation
supervisor: add into a chain's worker, no worker of its own and no move (#348) - #357
Merged
Merged
Conversation
…'s worker (#348) The add goes into the chain's worker at the end of the chain: no worker of its own and no move. The first add of a chain opens its worker; each add sends the worker the order with the new member. A member the worker refuses to run in the chain is removed and the add answers PLACEMENT_INVALID, so the caller adds it own. The add is refused the same way for a planned chain, a chain whose worker is not up, a quarantined plugin and, under require_pins, a format whose pin holds only in a world of its own.
This was referenced Nov 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds point 1 and 2 of #348:
add <uri> <inst> chain:<n>. The settled questions are in the issue body.Tests, red first: the two new daemon tests failed on main (
chain:7was read as a client name) and pass here. The fake host gains FAKE_REFUSE_CHAIN_MEMBER.make -k testpasses in the worker image.The add-time bench row follows in the release PR.