Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supersedes #430 (which covers only the
np.floatfix) and completes a fullmodern-Python compatibility chain for
yolox/tracker, following up on #466 where thethree blockers are consolidated. It covers (1) the numpy>=1.24 alias removal, (2) the
C++ toolchain requirement, and (3) the
lapwheel gap.Changes
np.floatremoved in numpy >= 1.24 (matching.py,byte_tracker.py)Replace the removed alias so the tracker no longer raises
AttributeError: module 'numpy' has no attribute 'float'on the firstupdate().(Supersedes Removed deprecated np.float #430.)
C++ toolchain required by
cython_bbox(cython_bbox_numpy.py,matching.py)matching.pyuses exactly one function fromcython_bbox(bbox_overlaps). This adds apure-numpy implementation with the same semantics (including the original +1 pixel
width/height convention) and imports it as a fallback through
try/except ImportError,so inference-only use of
yolox/trackerno longer requires MSVC /CppExtension- acommon failure on Windows and on slim CI images. Behaviour is unchanged whenever
cython_bboxis installed.laphas no wheel on some platforms (README)Documented that on platforms where
laphas no prebuilt wheel, thelapxdistributionships a module named
lap(samelapjvAPI), sopip install lapxsatisfies theexisting import with no code change. No code path is modified for this item.
Verification
bbox_overlapsshim are used in production ina downstream monocular AEB/FCW pipeline, covered by 41 zero-data regression tests (pytest collect) and CI
on Ubuntu/Windows x Python 3.10/3.12: https://github.com/H12Y10/mono-aeb
identical IoU matrices, including the +1 pixel convention and zero-overlap cases.
lapnote:pip install lapxwas verified to install a module namedlap(
import lapxfails as expected), andlapjvassignment results were identical tolapon the cost matrices we validated (same total cost, same
x/yassignment).License
Same MIT as the repository; the changes are minimal and do not alter tracking behaviour.