Repository navigation
Conversation
Forma's runtime now pairs a lookup's values with the arguments its key's expressions name as well as its holes, in the order each name first appears, and reads a gender expression beside a plural one. It also renamed PluralExpressionEvaluator to LocaleExpressionEvaluator, so Locali no longer built against Forma's dev. Expressions are parsed with the runtime's keywords, so a gender expression is read rather than reported as malformed. LOC0201 counts holes and expression arguments, and LOC0200 checks the names a lookup supplies and reads plural expressions alone; both had reported a lookup the runtime pairs correctly.
A gender expression falls back to its other field for a gender its fields do not name, a missing argument, or null, and renders nothing where it has no other field. LOC0218 warns of a gender expression that omits other, and LOC0219 reports a gender argument a lookup with no values never supplies, which always selects other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes candidate at e876f1b, whose full gate passed in run 44651346192, to main for the release of 1.0.0-preview.26. The changes are in the changelog's 1.0.0-preview.26 entry.