Repository navigation
Conversation
The README and the rules reference now say where a lookup Locali cannot check gets checked instead. From Forma 1.0.0-preview.9, the runtime's diagnostics, turned on in a development or test host, log a missing entry for a lookup that runs, at the assembly, the type or the key, in its UI culture and the cultures the host lists. They also say what each covers: Locali every lookup it can establish, the runtime the lookups a run exercises.
A lookup in a test project was followed through product code's registrations alone, so one reaching a stub locale factory the test registers was held to the type the host's factory would read. A type with no entries hid the false positive in Forma's ComponentContextFactoryTests. A walk now carries the test project its lookup or forwarded call sits in. A locale factory that test registers ends the path, a service is followed to the one implementation product code and the test register between them, and memoized answers are kept apart per test project.
A type lookups read with no entries in any culture its assembly's locale files carry was taken for one left unlocalized on purpose: LOC0207 checked none of its keys and LOC0119 compared none of its cultures, so a new component whose section was never written rendered every key in the source language with every check green. LOC0217 reports such a type as a warning, once per type and culture, at the first lookup reading it. A type with entries in any culture, a shared block's among them, stays with LOC0207 and LOC0119.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes candidate at 8280386, whose full gate passed in run 44134574777, to main for the release of 1.0.0-preview.24. The changes are in the changelog's 1.0.0-preview.24 entry.