Repository navigation
docs: add Storybook stories for ComponentErrorBoundary - #1237
Open
RiccardoBifulco wants to merge 1 commit into
Open
RiccardoBifulco wants to merge 1 commit into
RiccardoBifulco wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1176
Summary
Adds
components/error-boundary/component-error-boundary.stories.tsx, following the conventions ofsection-error-boundary.stories.tsx.Changes
Default: healthy child renders normallyWithError: child throws, compact fallback with Retry buttonWithErrorDefaultLabel: fallback with the default "component" labelWithSiblings: one broken component does not hide its siblingscaptureErroris mocked so Sentry is not hit from StorybookTest plan
npx vitest run: 122 files / 1541 tests passtsc --noEmit: no errors in the new filenpm run storybook:build: fails onmaintoo, before this change (TypeError: swc.isWasm is not a functionfrom@storybook/nextjsswc loader patch, 42 occurrences with or without this file), so I could not verify it locally*.stories.tsx, so lint reports nothing for the file