Is InsertUsingStoredProcedure, UpdateUsingStoredProcedure, DeleteUsingStoredProcedure in model builder supported? #1158

Activity

1. cincuranet

   self-assigned this

   on Feb 12, 2024
2. cincuranet

   added

   ef core

   type: bug

   on Feb 12, 2024
3. Camel-RD commented on Jul 10, 2024

   

   Camel-RD

   on Jul 10, 2024

   ContributorAuthor

   More actions

   Can we fix this issue with this code in FbUpdateSqlGenerator.cs?

   	public override ResultSetMapping AppendStoredProcedureCall(
   		StringBuilder commandStringBuilder,
   		IReadOnlyModificationCommand command,
   		int commandPosition,
   		out bool requiresTransaction)
   	{
   		var storedProcedure = command.StoreStoredProcedure;
   		var resultSetMapping = ResultSetMapping.NoResults;
   
   		foreach (var resultColumn in storedProcedure.ResultColumns)
   		{
   			resultSetMapping = ResultSetMapping.LastInResultSet;
   			if (resultColumn == command.RowsAffectedColumn)
   			{
   				resultSetMapping |= ResultSetMapping.ResultSetWithRowsAffectedOnly;
   			}
   			else
   			{
   				resultSetMapping = ResultSetMapping.LastInResultSet;
   				break;
   			}
   		}
   
   		commandStringBuilder.Append("EXECUTE PROCEDURE ");
   		SqlGenerationHelper.DelimitIdentifier(commandStringBuilder, storedProcedure.Name);
   
   		if (storedProcedure.Parameters.Any())
   		{
   			commandStringBuilder.AppendLine();
   			var first = true;
   
   			for (var i = 0; i < command.ColumnModifications.Count; i++)
   			{
   				var columnModification = command.ColumnModifications[i];
   				if (columnModification.Column is not IStoreStoredProcedureParameter parameter)
   				{
   					continue;
   				}
   
   				if (parameter.Direction.HasFlag(ParameterDirection.Output))
   				{
   					continue;
   				}
   
   				if (first)
   				{
   					first = false;
   				}
   				else
   				{
   					commandStringBuilder.Append(", ");
   				}
   				SqlGenerationHelper.GenerateParameterNamePlaceholder(
   					commandStringBuilder, columnModification.UseOriginalValueParameter
   						? columnModification.OriginalParameterName!
   						: columnModification.ParameterName!);
   			}
   		}
   
   		commandStringBuilder.AppendLine(SqlGenerationHelper.StatementTerminator);
   		requiresTransaction = true;
   		return resultSetMapping;
   	}
   
   
4. cincuranet commented on Jul 15, 2024

   

   cincuranet

   on Jul 15, 2024

   Member

   More actions

   Can you create PR?
5. cincuranet

   linked a pull request that will close this issueAdded AppendStoredProcedureCall #1185on Nov 7, 2024
6. cincuranet

   added the

   Bug

   issue type on Apr 11, 2025
7. cincuranet

   removed

   type: bug

   on Apr 11, 2025
8. cincuranet

   closed this as completedin #1185on Oct 9, 2026
9. cincuranet

   added this to the EFCore-vNext milestone on Oct 9, 2026