Repository navigation
Conversation
added 5 commits
May 23, 2022 16:11
Signed-off-by: Brandon J. Van Vaerenbergh <brandon@finitestate.io>
added 11 commits
June 1, 2022 10:09
…packaged_files Test assume builder always adds File to the last RDF Package? Seems wrong
bjamesv
marked this pull request as ready for review
June 13, 2022 19:32
njv299
reviewed
Jun 13, 2022
njv299
left a comment
njv299
left a comment
There was a problem hiding this comment.
Looking really good. Nice and clean changes that add the intended functionality without making any sweeping, potentially-controversial modifications.
Just a few nit-picky comments or suggestions for wording that might be a bit clearer. Happy to approve when you see fit 👍🏻
Author
|
Changes made + squashed to new branch, see PR #2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Files without associated packages, as allowed by the spec but not currently supported in Document class.
Also leverages the unpackaged Files data model, to fix rdf parser bug where every
referencesFileare incorrectly added to the last-listed Package.Resolves spdx/tools-python #181
Signed-off-by: Brandon J. Van Vaerenbergh brandon@finitestate.io