Repository navigation
Publish with JDK 17 locally and in publish.yml - #18
Merged
Merged
Conversation
…ml, stop on failed module builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradle 9.4 requires JDK 17, so every release run of
publish.ymlhas failed since 2.0.0 ("Gradle requires JVM 17 or later") and local publishes needed a manualJAVA_HOME.publish_to_repsy.shuses the newest sdkmanjava/17.*candidate when one is installed and otherwise keeps the caller'sJAVA_HOME(CI's setup-java). It prints the JDK it uses.set -eignored failures inside thecd ... && ./gradlew ... && cd -chains, and the script went on from inside./client(that's thechmod: cannot access './core/gradlew'error in the v3.1.0 run).publish.ymlsets up JDK 17 instead of 11.Verified by publishing v3.1.0 with this script from a shell whose default JDK is 21: it picked 17.0.17, all three modules built, and Repsy lists
client,coreandpubsub3.1.0.