Repository navigation
Chore/nomina catalog routes - #119
Merged
Merged
Conversation
javorosas
reviewed
Sep 18, 2026
raul-facturapi
force-pushed
the
chore/nomina_catalog_routes
branch
from
October 7, 2026 15:17
a668856 to
4e8681d
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review identified no blocking issues in the straightforward additive changes; automated tests were not run.
0 open findings
What changed in this PR
Adds payroll catalog searches to the Facturapi SDK for version 5.2.0.
Changes:
- Exposes deduction and perception searches through
facturapi.nominaCatalogs. - Documents the new methods and release.
- Applies formatting-only changes to invoice code and one test.
| File | Description |
|---|---|
| test/node/invoices-zip-requests.node.test.ts | Reformats a method call. |
| src/types/invoice.ts | Removes semicolons; no type changes. |
| src/tools/nominaCatalogs.ts | Adds payroll catalog search methods. |
| src/resources/invoices.ts | Formatting only; no behavior changes. |
| src/index.ts | Initializes and exposes nominaCatalogs. |
| README.md | Adds payroll catalog examples. |
| package.json | Bumps version to 5.2.0. |
| CHANGELOG.md | Documents the new catalog methods. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
javorosas
approved these changes
Oct 7, 2026
Member
|
Mi unica preocupación son los cambios de formateo/eslint que eliminan puntos y coma. Tenemos reglas de formateo inconsistentes? Tal vez algo a abordar en otro PR |
raul-facturapi
force-pushed
the
chore/nomina_catalog_routes
branch
from
October 8, 2026 16:42
4e8681d to
ecdb73a
Compare
javorosas
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.