Repository navigation
Conversation
Author
|
Complete error: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
pthread_create()compilation error in the FS-AI API.The
can_read_threadfunction was declared without parameters, butpthread_create()requires a thread function with the signature:The function now accepts the required void * argument and explicitly marks it as unused. Existing CAN reader behaviour is unchanged.
Issue
This issue is present when building the FS-AI API on Ubuntu 26.04 and ROS Lyrical. The compiler reports:
The error is caused by the incompatible function-pointer type passed to
pthread_create().Validation
pthread_create()complication error is resolved.Build environment
ament_cmake