Repository navigation
Conversation
Platform: ios New(zh-Hant): iPhone Duo 外螢幕與內螢幕橫放時,分頁列改放在右側直式欄,不再被系統狀態列擋住 New(en-US): on iPhone Duo the tab bar moves into the side system rail, clear of the status bar
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 5 selected item(s). |
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
這個 PR 做了什麼
iPhone Duo 出現系統側欄(外螢幕、內螢幕橫放)時,分頁列改成只有圖示的直式列,放進側欄裡;所有分頁的內容都排在側欄旁邊,不再被它蓋住。其他裝置的底部分頁列完全不變。
foldable套件回報有 hinge,且頂部 inset ≈ 0、單側 inset ≥ 60 pt、另一側小於其 1/3,才視為側欄模式(systemRailEdgeFor)。非 Duo 裝置與測試環境中套件回傳 unsupported,走原本路徑。MainShell在側欄模式下把內容縮到側欄旁、移除該側的 inset,側欄寬度等於系統給的 inset。FrostedSurface膠囊、貼齊底部,每格有Tooltip與Semantics標籤(文字沿用既有 l10n)。首頁 sheet 拉起、地圖沉浸模式時,跟底部列一樣淡出,只是往側欄外滑。相關 issue
沒有對應的 issue。
怎麼驗
test/app/shell/system_rail_test.dart:偵測規則(左右兩側、門檻、非側欄的橫放)、分頁列點擊與選取狀態。tool/check.sh全部 gate 通過(Darwin)。檢查清單
tool/check/commits.sh origin/main..HEAD通過tool/dev/analyze.sh與tool/dev/test.sh通過AppLocalizations,沒有寫死(沒有新增字串)