Repository navigation
Fixed setup.py and added a simple test file which can be run to check… - #4
Merged
Merged
Conversation
… basic functionality
| @@ -0,0 +1,12 @@ | |||
| # This is meant as a simple test file to check if psi/j was installed successfully | |||
|
|
|||
| from psi.j import SubmitException, Job, JobExecutor, JobSpec, JobState | |||
Collaborator
There was a problem hiding this comment.
Some imports are not used which probably will trip a linter.
Collaborator
Author
There was a problem hiding this comment.
Good point. The tests were not even checked.
I added the tests dir to "make checks" and removed the unused imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… basic functionality
Fixes #3
To check:
pip3 install -e . python3 tests/run_local_job.pyShould print something like