Skip to content

Update graphql-java 26.0 - #318

Open
richharms wants to merge 1 commit into
Enigmatis:masterfrom
echothreellc:1-upgrade-to-graphql-java-260
Open

richharms wants to merge 1 commit into
Enigmatis:masterfrom
echothreellc:1-upgrade-to-graphql-java-260

Conversation

@richharms

Copy link
Copy Markdown
Contributor

Summary

Updates the graphql-java dependency to 26.0 and makes a minor code adjustment to support it.

Type

  • Bug fix
  • Feature
  • Docs
  • Build/CI

Checklist

  • [X ] Includes tests (all existing tests pass)
  • Updates documentation if needed
  • Linked to issue: Fixes #____

Notes for reviewers

No additional notes.

@Fgerthoffert

Copy link
Copy Markdown
Collaborator

Sorry for the delay in reviewing, we will try to provide a review by end of September 2026.

@geichelberger

Copy link
Copy Markdown
Contributor

Would it be possible to release this version or version 26.1 after it has been reviewed?

@Fgerthoffert

Copy link
Copy Markdown
Collaborator

Yes, I believe we'll try to trigger releases once the open PRs have been merged.

Sorry for the delay, we didn't get a chance to get to it, but hope to get it done in the coming month.

@RedN4ks RedN4ks left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upgrade, and sorry for the long wait.

graphql-java 26.0 and 26.1 were published without OSGi headers (Bundle-SymbolicName, Export-Package), while 24.x and 25.x had them. This library is built and used as an OSGi bundle, so with this upgrade:

  • the Import-Package we generate for graphql.* loses its version range ([24.3,25) today, no range on this branch);
  • in an OSGi container, no bundle can import the graphql packages from graphql-java 26.x. I checked this in Apache Felix: missing requirement osgi.wiring.package=graphql.

CI doesn't catch this because our tests don't run in an OSGi container. It's an upstream build regression, reported in graphql-java/graphql-java#4547, with a fix proposed in graphql-java/graphql-java#4548.

There's nothing wrong with your PR. I'd just prefer to merge and release once the OSGi issue is fixed upstream. When a graphql-java release includes the fix, I'll ping you so you can bump the graphql-java version here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants