Repository navigation
[1.16] Add Iris/Oculus shader detection to renderer compatibility handling - #348
Open
suke-maboroshi wants to merge 1 commit into
Open
suke-maboroshi wants to merge 1 commit into
suke-maboroshi wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Iris/Oculus shader-state detection to Flywheel's renderer compatibility handling.
Iris/Oculus does not use OptiFine's
net.optifinepackage, so the existing shader detection did not recognize it. As a result, Flywheel could perform OpenGL program state resets while an Iris/Oculus shader pack was active, causing repeated OpenGL errors such asGL_INVALID_OPERATION: No active program.Changes
net.irisshaders.iris.api.v0.IrisApi) using reflection, keeping Iris/Oculus an optional dependency.isShaderPackInUse()when checking whether Flywheel's rendering backends can be used.Testing
Tested with:
The OpenGL error spam was reproduced with shaders enabled and no longer occurred after applying this change.
Notes
This change does not add Flywheel instancing support while Iris/Oculus shaders are active. Instead, it disables the affected Flywheel rendering backends while shaders are in use, following the existing conservative compatibility approach.