Repository navigation
Snowflake: Preserve CREATE DATABASE batch delimiters - #43
Merged
Vedin merged 5 commits intoNov 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CREATE DATABASE demo; USE DATABASE demo; SELECT 1fails atUSEbecause the Snowflake CREATE DATABASE parser consumes the semicolon expected by the outer statement loop. Leave that delimiter for the caller, retaining the existing EOF behavior.Three batch controls fail before the fix and the single-statement/delimiter-negative control passes. All-features tests pass (1,553 passed, 7 ignored), including all four regression controls; formatting and CI-pinned Rust 1.89 all-target/all-feature Clippy with
-D warningspass. Host Rust 1.99 reports the same seven pre-existing lint diagnostics on the unchanged baseline.The existing license workflow could not install Python 3.8 on the current Ubuntu runner. Use Python 3.12 and fail immediately on audit-tool errors. Both Rust and license workflows pass on the final head (4800063).
Targets the active compatibility branch pinned by Rustice.