Skip to content

Secp operations during txid computation #202

Closed

Description

@RCasatta

In a performance profile in a downstream project I noticed txid() is taking too much time even considering it's an expensive computation, in the flame graph there were calls to secp function which I don't think should happen?

Can share the performance graph if can help understand

Activity

  1. apoelstra commented on May 9, 2024

    @apoelstra
    Member

    Sure. What secp function was it?

  2. RCasatta commented on May 9, 2024

    @RCasatta
    CollaboratorAuthor

    I had to leave the PC... I remember fe_sqrt and others, will post tomorrow

  3. RCasatta commented on May 10, 2024

    @RCasatta
    CollaboratorAuthor

    Here are a convenient screenshot and the profiler json (to be loaded from chrome dev tools, performance tab)

    For what I understand is how the PedersenCommitment is serialized with secp256k1_pedersen_commitment_serialize

    image

    Trace-20240510T085107.json

  4. apoelstra commented on May 10, 2024

    @apoelstra
    Member

    Ok, yeah, the issue is in libsecp256k1-zkp, not here. For some bizarre reason secp256k1_pedersen_commitment_serialize decompresses the point then recompresses it, when all it needs to do is a memcmp (I think). So this function is wasting a lot of time for no reason.

  5. RCasatta commented on Jul 1, 2024

    @RCasatta
    CollaboratorAuthor

    Issue has been fixed in the upstream lib, I think we need

    • secp256k1-zkp-sys upgrade to catch the changes
    • rust-secp256k1-zkp release
    • upgrade dep here (if rust-secp256k1-zkp not released as patch version)
  6. apoelstra commented on Jul 9, 2024

    @apoelstra
    Member

    Bumping secp-zkp requires bumping secp, which requires bumping bitcoin, which requires bumping bitcoind, which requires bumping elementsd.

    I am almost done this. Opened RCasatta/elementsd#18

  7. apoelstra commented on Jul 9, 2024

    @apoelstra
    Member

    The next version of rust-bitcoin will break out the "types that never change" into a new primitives crate which should be sufficient for most of the other crates in the ecosystem, and which should rarely have major version bumps, which will make this all way less painful.

  8. RCasatta commented on Sep 23, 2024

    @RCasatta
    CollaboratorAuthor

    Fixed with #209
    next release will take this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions