Ideal Version of Enforcing Poetry Version #113

Activity

1. keithrfung

   added

   hacktoberfestIssues for the HacktoberfestIssues for the Hacktoberfest

   on Oct 1, 2020
2. keithrfung

   changed the title [-]Better version of locking Poetry Version[/-] [+]Ideal Version of Enforcing Poetry Version[/+] on Oct 1, 2020
3. TuTomasz commented on Oct 8, 2020

   

   TuTomasz

   on Oct 8, 2020

   More actions

   I had an idea how to possibly approach this issue.

   POETRY_VERSION = 1.0.10
   
   all: environment lint start
   
   environment:
   	@echo 🔧 SETUP
   	make install-gmp
   	@echo Check if need cleanup
   	[ -f ./.env ] && rm -r .env || echo env file not found
   	[ -f ./poetry.lock ] && rm -r poetry.lock || echo lock file not found
   	touch .env
   	@echo Install Poetry Version $(POETRY_VERSION)
   	pip install --upgrade --force-reinstall 'poetry==$(POETRY_VERSION)'
   	@echo Install Dependencies
   	poetry install
   	@echo POETRY_VERSION==$(POETRY_VERSION) > .env

   Something like this would possibly tackle the first two points of enforcing that the existing environment is always correct regenerating lock files and re-installing dependencies on version change. Also, generate .env with that specific Poetry version defined in the makefile (could be used for other future constants).

   This .env file would be used in docker-compose.yml and in dockerfile to pass the correct Poetry version (other constants) when generating containers. This would ensure the third point of containers always having the right Poetry version passed. All that is taken care of when you use "make environment".

   And lastly, for the fourth point, this approach regenerates a lock file on every "make environment" call so that way there shouldn't be any version conflicts and incompatible lock files. Let me know if I'm missing something here.
4. lmarie79

   added

   triageWaiting to be triagedWaiting to be triaged

   on Sep 28, 2021
5. keithrfung

   removed

   triageWaiting to be triagedWaiting to be triaged

   on Oct 6, 2021
6. keithrfung commented on Oct 6, 2021

   

   keithrfung

   on Oct 6, 2021

   ContributorAuthor

   More actions

   @TuTomasz You really hit it out of the park with that answer. I'm sorry I missed it. This seems like right approach.
7. keithrfung

   added

   enhancementNew feature or requestNew feature or request

   good first issueGood for newcomersGood for newcomers

   help wantedExtra attention is neededExtra attention is needed

   on Oct 7, 2021