Repository navigation
Conversation
[Medium impact] The reviewed changes appear safe to merge.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed?
as discussed over email, the anthropic service default moves from
claude-sonnet-4-5-20250929toclaude-sonnet-5-5.Why?
sonnet 4.5 retires on nov 30, 2026. per the migration guide, sonnet 5.5 rejects
temperature,top_pandtop_k, so for that model i drop them from the stream request (including overrides fromextra). the non streaming path now joins text blocks instead of readingcontent[0], since a thinking block can come first.one thing i left alone on purpose: sonnet 5.5 thinks adaptively by default, and tool continuations normally replay the signed thinking block. the streaming loop doesn't keep those yet. happy to add that in a follow up if you want, it touches the context aggregator so i didn't want to guess at your design here.
How to Test?
PYTHONPATH=src pytest tests/test_services/test_anthropic_llm.py --disable-socket --allow-unix-socket -q(6 passed, python 3.11, mocked sdk, no network). black and ruff pass on the touched files.Release Label
fixChecklist
CONTRIBUTING.mdguide.