Repository navigation
fix: resolve DisplayAttributeInfoEnum UAF, atomic COM refCount, and null guards - #13
Merged
Merged
Conversation
…extService - Guard selKeys_ bounds in CandidateWindow recalculateSize and paintItem, and clamp candPerRow in itemRect to prevent division by zero. - Add null-checks for threadMgr_ and docMgr in TextService::currentContext(). Generated with assistance from Antigravity (Gemini 3.8 Flash)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves several memory safety and stability issues in
libIME2:DisplayAttributeInfoEnum.cpp,displayAttrInfoswas previously bound as a value copy of the container (auto displayAttrInfos = ...), causingiterator_to become dangling once the constructor exited. In applications like Microsoft Word that enumerate display attributes, accessing the iterator led to heap corruption and crashes. Binding by reference (auto& displayAttrInfos) fixes this.++refCount_and--refCount_inComObject.hwithInterlockedIncrementandInterlockedDecrementwithvolatile LONG refCount_to ensure thread-safe lifetime management across multi-threaded COM calls.threadMgr_anddocMgrinTextService::currentContext().selKeys_indexing inrecalculateSize()andpaintItem()against out-of-bounds access whenitems_exceedsselKeys_, and clampedcandPerRow = std::max(1, candPerRow_)initemRect()to prevent division by zero.Generated with assistance from Antigravity (Gemini 3.8 Flash)