Skip to content

Move logging backend to spdlog - #23

Draft
hikinggrass wants to merge 47 commits into
mainfrom
feature/spdlog
Draft

Move logging backend to spdlog#23
hikinggrass wants to merge 47 commits into
mainfrom
feature/spdlog

Conversation

@hikinggrass

@hikinggrass hikinggrass commented Aug 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Replaces the currently used logging backend "Boost.Log" with "spdlog".
This is a drop-in replacement, especially currently used config files should work without any modification, however this does mean we still depend on "Boost.Log" for the parsing of the configuration files

@hikinggrass
WIP: use spdlog instead of Boost.Log
30dcacf 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Initialize line with 0
182d3eb 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Replace EVLOG_AND_THROW and EVTHROW macros with constrexpr functions
1dd6462 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Address some clang-tidy issues
bda0c19 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Add LogSource operator<< to control file name, line number and functi…
bd39374 
…on in the log

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Update example to showcase more features
362be38 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Fix gtest integration, add some first unit tests, fix coverage genera…
8365d5b 
…tion

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Change Filter in example logging.ini to show the %Process% contains s…
6bfd5ed 
…yntax

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Small log fix
6846122 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Fix is_level with and without %Process% contains
8bd88f8 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Implement a (hopefully) Boost.Log TextFile settings compatible rotati…
37e5b9c 
…ng file sink based on the rotating file sink example of spdlog

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Implement a simple Syslog sink
ee92a57 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Correctly limit maximum number of files in log rotation
2133f3c 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Respect file name and extension set in FileName when using default fo…
47aa3da 
…rmat string

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Convert EVEREST_INTERNAL_LOG_AND_THROW into constexpr template function
78ab778 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Throw EverestConfigError when no sinks are configured
5729b5d 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Add unit tests for Console and TextFile sinks
989eb46 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Set LOG_INSTALL to OFF in edm mode
c65ff9d 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Prefix coverage targets with PROJECT_NAME
db29554 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Add syslog smoketests
e221a54 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Add console defaults smoketest
a4d8c2c 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Add unit test for trace functionality
be05d33 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Generate code coverage and upload gcovr coverage report as artifact
4922edb 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
clang-format
5e1ddc3 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Only set cmake_policy CMP0167 (FindBoost handling) in cmake >= 3.30
c2bb124 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
install gcovr 6
e40185a 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Copy ctest-report and gcovr-coverage after install_and_test.sh for up…
4e876bb 
…loading as artifacts

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Attempt to fix path of gcovr output dir
7e12452 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
path fix
84ab5a7 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
revert last commit
68294cd 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
fix trap
213f21b 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Rewrite trap
0abde84 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
ls build
18280b8 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Fix gcovr-coverage path
8e6227d 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Fix usage of current_process_name
e390203 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Make ctors with one argument explicit
3d07bb9 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Fix get_process_name()
b4e088c 
/proc/PID/cmdline is NUL separated, treat it as such for parsing

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Add RotateOnOpen option to TextFile sink
0175b70 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Add test for a broken format string in TextFile FileName
cfba2e3 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass hikinggrass changed the title Feature/spdlog Move logging backend to spdlog Aug 19, 2024
@hikinggrass
hikinggrass marked this pull request as ready for review August 20, 2024 08:48
@Pietfried
Pietfried requested a review from andistorm August 20, 2024 08:51
SebaLukas
SebaLukas approved these changes Aug 20, 2024
View reviewed changes

@SebaLukas SebaLukas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my fedora 40 system without problems 👍

andistorm
andistorm reviewed Sep 2, 2024
View reviewed changes
Comment thread .ci/build-kit/install_and_test.sh Resolved
Comment thread CMakeLists.txt Resolved
Comment thread CMakeLists.txt Resolved
Comment thread dependencies.yaml Resolved
andistorm and others added 7 commits September 2, 2024 15:43
@andistorm
Update CI
501a003 
* Add `build-kit-liblog`
* Use newer `build-kit-base`
* Split up scripts
* Refactor `build_and_test` workflow file

Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
@andistorm
github.token -> secrets.GITHUB_TOKEN
6a15995 
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
@andistorm
Add trailing slash
ee04556 
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
@andistorm
Fix build dir path
7246769 
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
@hikinggrass
Add missing newline
ffb6ef1 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Remove redundant enable_testing()
7e93da5 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
Move coverage targt setup to tests subdir
eb62bb2 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass hikinggrass mentioned this pull request Sep 3, 2024
Closed
andistorm
andistorm approved these changes Sep 3, 2024
View reviewed changes

@andistorm andistorm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐧

@hikinggrass
Add gcovr coverage xml target
608bb48 
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass
hikinggrass marked this pull request as draft January 3, 2025 11:18
@hikinggrass hikinggrass mentioned this pull request Mar 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andistorm andistorm andistorm approved these changes
@SebaLukas SebaLukas SebaLukas approved these changes

Assignees

@andistorm andistorm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hikinggrass @andistorm @SebaLukas