Repository navigation
#476 DefaultValidator.getValidInput uses canonicalize method argument - #477
Merged
Merged
Conversation
Exposing behavior in the StringValidationRule to allow an implementor to opt-out of encoder canonicalization behavior. Tests added to verify intended behavior. DefaultValidator getValidInput has been updated to use the existing canonicalize argument to configure the StringValidationRule delegate for canonicalization behavior before validating the input reference. Tests updated to validate configuration occurs in workflow. Additional test updates in the DefaultValidatorInputStringAPITest to remove unnecessary mock configuration expectations, and to verify that all expected mock interactions have occurred.
Adding recommended logging if canonicalization is set to false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation and test updates consistent with the recommended approach. StringValidationRule behavior for canonicalization is now configurable & DefaultValidator uses that configuration when evaluating a valid String input.
Tests updated to match expectations.