Repository navigation
Mixed check - #8960
Mixed check#8960galeksandrp wants to merge 2 commits into
Conversation
|
This cannot replace manual review, but it could be a help. |
Hainish
left a comment
There was a problem hiding this comment.
Even if a PR does introduce active mixed content, we don't want the tests to fail for it. It might be nice to know (perhaps with a github label?) but lots of sites have some active mixed content blocked and this does not at all impede site functionality.
| - TEST=chromium | ||
| - TEST=rules | ||
| - TEST=fetch | ||
| - TEST=preloaded |
| www.freerunet.ru self signed | ||
| --> | ||
| <ruleset name="freerunet.ru" platform="mixedcontent"> | ||
| <ruleset name="freerunet.ru"> |
There was a problem hiding this comment.
let's keep changes granular. this belongs in another PR
|
|
||
| if [ "$TEST" == "mixed" ]; then | ||
| echo >&2 "Ensuring rulesets do not introduce targets containing active mixed content." | ||
| docker run --rm -ti -v $(pwd):/opt -e RULESETS_CHANGED="$RULESETS_CHANGED" node bash -c "cd /opt && apt-get update && apt-get install -y libxml2-utils && npm install -g galeksandrp/check-mixed-content#245e56ad5fd5412bdad986276911e5460d9e48c6 && xmllint --xpath '//ruleset[not(@platform)]/target' $RULESETS_CHANGED | grep -q -v '^$' || exit 0 && xmllint --xpath '//ruleset[not(@platform)]/target' $RULESETS_CHANGED | sed 's/<target host=\"//g' | sed 's&\"/>&\n&g' | grep -v '*' | xargs -n1 -i bash -c 'check-mixed-content --depth=1 --url {}' | grep ' has active mixed content!' && exit 1" |
There was a problem hiding this comment.
This belongs in a utils/ subpath, as we've done before for other tests.
|
If it's possible to add labels depending on Travis results there would be a lot of use cases for it. |
|
Maybe we can use this tool to fix #529? |
If you are not impressed by franciskim/check-mixed-content@master
check-mixed-content --depth=1 --url {}can be replaced by bramus/mixed-content-scan@master