Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update Sohu.com.xml - #7548

Closed
ivysrono wants to merge 28 commits into
EFForg:masterfrom
ivysrono:patch-311
Closed

ivysrono wants to merge 28 commits into
EFForg:masterfrom
ivysrono:patch-311

Conversation

@ivysrono

Copy link
Copy Markdown
Contributor

No description provided.

- Sohu.net.xml
-->

<ruleset name="Sohu.com-mixedcontent">

@youdly youdly Nov 13, 2016 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repalce with <ruleset name="Sohu.com-mixedcontent" platform="mixedcontent">
See MCB section of ruleset guide.

@ivysrono ivysrono Nov 13, 2016 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
All of these rules could be enabled by default.
They won't cause MCB.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's the case, why not combine them into Sohu.com.xml.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too complicated

<exclusion pattern="^http://push\.my\.tv\.sohu\.com/$" />
<rule from="^http://push\.my\.tv\.sohu\.com/(\S+)\.json"
to="https://push.my.tv.sohu.com/$1.json" />
<test url="http://push.my.tv.sohu.com/getwebpush_sohuHD.globalNewPushTrigger.json" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging from the ruleset test, I think you need to add one more link with .json.

@ivysrono ivysrono closed this Dec 28, 2016
@ivysrono ivysrono reopened this Dec 28, 2016
@ivysrono ivysrono closed this Dec 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants