Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Create So.com.xml - #7519

Merged
J0WI merged 2 commits into
EFForg:masterfrom
gloomy-ghost:gloomy-ghost-so_com
Oct 23, 2017
Merged

J0WI merged 2 commits into
EFForg:masterfrom
gloomy-ghost:gloomy-ghost-so_com

Conversation

@gloomy-ghost

Copy link
Copy Markdown
Collaborator

No description provided.

@gloomy-ghost
gloomy-ghost force-pushed the gloomy-ghost-so_com branch 2 times, most recently from f26939a to ca3961a Compare November 8, 2016 05:23
@gloomy-ghost gloomy-ghost reopened this Nov 8, 2016
@Hainish Hainish added the top-100 label Nov 8, 2016
@jeremyn

jeremyn commented Nov 13, 2016 •

Copy link
Copy Markdown
Contributor

Mark as 403:

Mark as Invalid certificate:

Mark as Time out:

Add target:

Also:

  • Change https://api.app.m.so.com from 403 to Mixed content. The root URL gets a 403 with both (unencrypted) HTTP and HTTPS. The specific pages I checked from Google have different mixed content blocking problems.
  • For https://tran.news.so.com I get a 403 for both (unencrypted) HTTP and HTTPS. I can't find anything other than the root URL so I don't know if this is the same problem as https://api.app.m.so.com . I think tran.news.so.com should be a target.

@jeremyn jeremyn self-assigned this Nov 13, 2016
@gloomy-ghost gloomy-ghost reopened this Nov 14, 2016
@gloomy-ghost

Copy link
Copy Markdown
Collaborator Author

dev.yunpan.360.cn redirects to https itself, 404 in https though.

@jeremyn

jeremyn commented Dec 20, 2016

Copy link
Copy Markdown
Contributor

@gloomy-ghost Can you please take a look at this one?

@gloomy-ghost

Copy link
Copy Markdown
Collaborator Author

http://dev.yunpan.360.cn/ (200)

<html>  
<meta http-equiv="refresh" content="0;url=https://dev.yunpan.360.cn/">  
</html> 

https://dev.yunpan.360.cn/ (404)

@jeremyn

jeremyn commented Dec 21, 2016

Copy link
Copy Markdown
Contributor

Are you saying the problem with the test should be ignored because the plain HTTP version of the page already does a meta-refresh to the broken HTTPS version of the page?

@gloomy-ghost

Copy link
Copy Markdown
Collaborator Author

There are still some results in search engines, so maybe it just became broken some days ago. I can't tell if it's temporarily or permanently. What would you prefer?

@jeremyn

jeremyn commented Dec 21, 2016

Copy link
Copy Markdown
Contributor

I'm not sure what you are asking me.

@gloomy-ghost

Copy link
Copy Markdown
Collaborator Author

If it's a temporary error and will be fixed soon, there is no point to comment it and re-enable it days after.

If it's abandoned, I'm not sure do we even need to keep it in comments.

@J0WI

J0WI commented Oct 9, 2017

Copy link
Copy Markdown
Contributor

@gloomy-ghost what is the state of this PR?

@gloomy-ghost
gloomy-ghost force-pushed the gloomy-ghost-so_com branch 2 times, most recently from c5d7cae to fef00d3 Compare October 12, 2017 22:13

@J0WI J0WI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.
@jeremyn do you see anything else preventing this from merge?

<target host="yunpan.360.cn" />
<target host="*.yunpan.360.cn" />
<test url="http://c2.yunpan.360.cn/" />
<test url="http://c12.yunpan.360.cn/" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide one more test url here?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any numbers from 1 to 13 IIRC. They are shutting down this service shortly, so if there are any issues regarding the yunpan.360.cn subdomain I might just remove them altogether.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just because we require 3 in our style guide

Add one more test
@J0WI
J0WI merged commit 6c5b5ed into EFForg:master Oct 23, 2017
@jeremyn

jeremyn commented Oct 23, 2017

Copy link
Copy Markdown
Contributor

It doesn't really matter now, but I've updated the now-completed checklist in #7519 (comment) including modifying some of the requested changes.

@J0WI Thanks for taking this one over.

@gloomy-ghost
gloomy-ghost deleted the gloomy-ghost-so_com branch October 24, 2017 08:22
@gloomy-ghost gloomy-ghost removed their assignment Nov 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants