Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Calacademy.org make trivial rule. - #7517

Merged
gloomy-ghost merged 3 commits into
EFForg:masterfrom
jish:calacademy-org
Nov 12, 2016
Merged

gloomy-ghost merged 3 commits into
EFForg:masterfrom
jish:calacademy-org

Conversation

@jish

@jish jish commented Nov 7, 2016

Copy link
Copy Markdown
Contributor

Also added:

  • store.calacademy.org
  • ticketing.calacademy.org

Also added:

* store.calacademy.org
* ticketing.calacademy.org
@Hainish Hainish added the top-1m label Nov 8, 2016
@gloomy-ghost

gloomy-ghost commented Nov 12, 2016 •

Copy link
Copy Markdown
Collaborator

Thanks.

Please remove targets and note as incomplete certificate chain:

Note as Invalid certificate:

  • calendar.calacademy.org
  • hotels.calacademy.org
  • libcat.calacademy.org
  • pages.calacademy.org
  • research.calacademy.org
  • sacportal.calacademy.org
  • m.stg.calacademy.org

Timeout:

  • archdrop.calacademy.org
  • casp.calacademy.org
  • chat.calacademy.org
  • collections.calacademy.org
  • ipt.calacademy.org
  • myexplorer.calacademy.org
  • phylocluster.calacademy.org
  • researcharchive.calacademy.org
  • sengis.calacademy.org
  • www-dr.calacademy.org
  • zeus.calacademy.org

PROTOCOL_ERROR:

  • multisite.calacademy.org

Add targets:

  • apps.calacademy.org
  • archivesadmin.calacademy.org
  • jira.calacademy.org
  • kronos.calacademy.org
  • legacy.calacademy.org
  • monarch.calacademy.org
  • sso.calacademy.org
  • vpn.calacademy.org

Also:

  • Choose a style of comment.
  • Remove legacy.calacademy.org and note as redirect to http

@gloomy-ghost gloomy-ghost self-assigned this Nov 12, 2016
@jish

jish commented Nov 12, 2016

Copy link
Copy Markdown
Contributor Author

I've added and removed the domains listed.

I'm not sure how to use the legend at the bottom of the comment, so I looked through some of the other commits and found one letter notations at the end of the line wrapped in parenthesis, so I followed that convention.

subdomain.example.org (t)

Let me know if anything looks off.

@gloomy-ghost

Copy link
Copy Markdown
Collaborator

There are some different styles of comments, you can have a look at #6868

I personally prefer listing subdomains in categories. It's ok if you want to list them in order and mark their status one by one, but it's wired to use both styles in one ruleset.

@gloomy-ghost

Copy link
Copy Markdown
Collaborator

I've updated #7517 (comment)

We can't secure legacy after remove www, I'm sorry for that.

@jish

jish commented Nov 12, 2016

Copy link
Copy Markdown
Contributor Author

I removed legacy.calacademy.org and added as a comment.

I'm sorry for all of the back and forth, the tests do not run properly on my machine. When I run bash test.sh a new instance of Firefox opens up and just sits there and does nothing forever. Both my Terminal and the new Firefox instance will both just hang forever.

@gloomy-ghost

Copy link
Copy Markdown
Collaborator

I'm using Windows, so I usually leave the testing to Travis CI. But did you run install-dev-dependencies.sh before testing?

The ruleset is good, thanks.

@gloomy-ghost
gloomy-ghost merged commit 8c4cae0 into EFForg:master Nov 12, 2016
@gloomy-ghost gloomy-ghost removed their assignment Nov 12, 2016
@jish

jish commented Nov 12, 2016

Copy link
Copy Markdown
Contributor Author

"I'm using Windows, so I usually leave the testing to Travis CI."

I'm using Mac OS, but I guess Travis CI will have to be my strategy as well.

"did you run install-dev-dependencies.sh before testing?"

Yes, I did.

@jish
jish deleted the calacademy-org branch November 12, 2016 21:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants