Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update SLU.se.xml - #7504

Merged
J0WI merged 6 commits into
EFForg:masterfrom
gloomy-ghost:gloomy-ghost-slu_se
May 11, 2017
Merged

J0WI merged 6 commits into
EFForg:masterfrom
gloomy-ghost:gloomy-ghost-slu_se

Conversation

@gloomy-ghost

Copy link
Copy Markdown
Collaborator

Close #7502

@ghost

ghost commented Nov 4, 2016 •

Copy link
Copy Markdown

1 line is not right, it's should be internt.slu.se not internet.slu.se
Please fix it.
Please add subdomains https://student.slu.se, https://webmail.slu.se and https://www.universitetsdjursjukhuset.se/

@jeremyn

jeremyn commented Nov 24, 2016 •

Copy link
Copy Markdown
Contributor

Please:

Mark as Different HTTP/HTTPS content:

Mark as No working URL known:

Mark as Refused:

Add (incomplete certificate chain) after these domains:

Add target:

Also:

  • Rename Protocol Error to Other SSL error
  • Remove the securecookie, there are too many non-working subdomains

Remove these entirely. My logic is that we shouldn't mention domains that fail both HTTPS and plain HTTP, even if they fail for different reasons.

@jeremyn jeremyn self-assigned this Nov 24, 2016
@gloomy-ghost

Copy link
Copy Markdown
Collaborator Author

Ouch, this was generated by a earlier version script, thanks for checking them. I'll do it after.

BTW mittslu.slu.se is working for me now.

@jeremyn

jeremyn commented Nov 25, 2016

Copy link
Copy Markdown
Contributor

I've moved https://mittslu.slu.se to the (incomplete certificate chain) part of the checklist.

@jeremyn jeremyn mentioned this pull request Nov 26, 2016
14 of 18 tasks
@ghost

ghost commented Dec 23, 2016

Copy link
Copy Markdown

Is it possible to merge the partial changes?

@jeremyn

jeremyn commented Dec 23, 2016

Copy link
Copy Markdown
Contributor

@gloomy-ghost Please add a comment when you're ready for me to review everything.

@gloomy-ghost

Copy link
Copy Markdown
Collaborator Author

@jeremyn It's getting a bit messy, can we have a check that how much of the list are done at the moment?

@jeremyn

jeremyn commented Dec 24, 2016

Copy link
Copy Markdown
Contributor

@gloomy-ghost Sure. Can you please squash just the commits between and including b57397f and f4bf206 to make it easier to check what's changed?

@jeremyn

jeremyn commented Dec 24, 2016

Copy link
Copy Markdown
Contributor

@Jony0008 If we only merged the partial changes, I think we would need to create a new pull request to do the rest, which would be confusing.

  Trimming comments based on scanning results.

  More trimming (both refused)

  Add targets

  Incomplete cert chain and cert mismatch
@jeremyn

jeremyn commented May 7, 2017

Copy link
Copy Markdown
Contributor

@gloomy-ghost Is this done and ready for a full review of the checklist?

@gloomy-ghost

gloomy-ghost commented May 8, 2017 via email

Copy link
Copy Markdown
Collaborator Author

@jeremyn

jeremyn commented May 8, 2017

Copy link
Copy Markdown
Contributor

I've updated the checklist through 2ae8a60.

@jeremyn

jeremyn commented May 9, 2017

Copy link
Copy Markdown
Contributor

I've freely updated the checklist in #7504 (comment) without marking all changes, for example I've deleted rather than crossed out many items from under Remove these entirely that now seem to be correct in the pull request. I guess there is heavy overlap with the changes I made and the items in @gloomy-ghost 's comment here, but I did not go through that comment to make the updates.

I've also pushed changes to fix the remaining problems in the checklist. This pull request should now be ready to go.

@J0WI Could you review this please?

@jeremyn jeremyn removed their assignment May 9, 2017
@J0WI
J0WI merged commit 9cca7b9 into EFForg:master May 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants