Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Added rule for profiseller.de. - #7488

Merged
gloomy-ghost merged 8 commits into
EFForg:masterfrom
Jochen-A-Fuerbacher:profiseller-de
Dec 4, 2016
Merged

gloomy-ghost merged 8 commits into
EFForg:masterfrom
Jochen-A-Fuerbacher:profiseller-de

Conversation

@Jochen-A-Fuerbacher

Copy link
Copy Markdown
Contributor

No description provided.

@gloomy-ghost

Copy link
Copy Markdown
Collaborator

Thanks. Please add a comment to the top saying that the other subdomains don't have valid certificates, and most of them are just redirecting to the main site.

Rewrite p[\d]+.profiseller.de and www.p[\d]+.profiseller.de to https://www.profiseller.de/shop1/index.php3?ps_id=%number% if you want.

@gloomy-ghost gloomy-ghost self-assigned this Nov 11, 2016
@Jochen-A-Fuerbacher

Copy link
Copy Markdown
Contributor Author

@gloomy-ghost Done.

@gloomy-ghost

Copy link
Copy Markdown
Collaborator

The list is too long so please don't list them. You can just use the suggestion at #6863 (comment)

Also the rules need tests, see https://travis-ci.org/EFForg/https-everywhere/jobs/180930047#L211

@@ -0,0 +1,17 @@
<ruleset name="Profiseller">

<!-- Some subdomains don't have valid certificates. -->

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And redirect to www

@Jochen-A-Fuerbacher

Copy link
Copy Markdown
Contributor Author

@gloomy-ghost Thanks for your feedback. Added tests.

@gloomy-ghost

Copy link
Copy Markdown
Collaborator

Also rules won't take effects unless the targets are listed. I suggest a wildcard here. (Note: rewrite ^http://(www\.)profiseller\.de/ and remove ^http: after add a wildcard target)

@gloomy-ghost

Copy link
Copy Markdown
Collaborator

Sorry for small pieces of comments, I'm typing on my phone :-|

@gloomy-ghost

Copy link
Copy Markdown
Collaborator

Thanks, merged.

@gloomy-ghost
gloomy-ghost merged commit 59a40d3 into EFForg:master Dec 4, 2016
@gloomy-ghost gloomy-ghost removed their assignment Dec 4, 2016
@Jochen-A-Fuerbacher
Jochen-A-Fuerbacher deleted the profiseller-de branch December 4, 2016 08:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants