Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update McAfee.xml - #6986

Merged
J0WI merged 7 commits into
EFForg:masterfrom
gloomy-ghost:gloomy-ghost-McAfee
Oct 7, 2016
Merged

J0WI merged 7 commits into
EFForg:masterfrom
gloomy-ghost:gloomy-ghost-McAfee

Conversation

@gloomy-ghost

Copy link
Copy Markdown
Collaborator

Close #5037

Waiting the result of discussion at #6985

  add working subdomains in EFForg#5037
  Comment problematic subdomains in EFForg#5037
@gloomy-ghost
gloomy-ghost force-pushed the gloomy-ghost-McAfee branch 3 times, most recently from 1cd086e to 6ed229c Compare September 24, 2016 05:12
Comment thread src/chrome/content/rules/McAfee.xml Outdated
<target host="att-beta.mcafee.com" />

<target host="beta.mcafee.com" />
<exclusion pattern="^http://beta\.mcafee\.com/(?![Bb][Ee][Tt][Aa][Mm][Cc][Aa][Ff][Ee][Ee]/\S).*" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

urls are handled case insensitive anyway.
It's also not clear for me what you try to exclude here or why this exclusion is needed.
I think the \S and .* excludes more than necessary.

Comment thread src/chrome/content/rules/McAfee.xml Outdated

<rule from="^http:"
to="https:" />
<securecookie host=".+" name="." />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name should also be .+

Comment thread src/chrome/content/rules/McAfee.xml Outdated
@@ -2,91 +2,162 @@
For other Intel coverage, see Intel.xml.

Other McAfee rulesets:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessary since they are already listed in Intel.xml

Rename McAfee_Mobile_Security.xml to McAfee-Mobile-Security.xml
@gloomy-ghost

Copy link
Copy Markdown
Collaborator Author

@J0WI Do you think we need a list of domains that even not existing in DNS record? I want to delete them all.

@J0WI

J0WI commented Oct 5, 2016

Copy link
Copy Markdown
Contributor

If a DNS record has been dropped, the host can also be removed from the ruleset.

I cannot reproduce the http redirect on beta.mcafee.com. It redirects to beta.mcafee.com/betamcafee/, but it seems that everything works with https. Has this been reported by our tests?

@gloomy-ghost

Copy link
Copy Markdown
Collaborator Author

Here is what I've got:

GET / HTTP/1.1
Host: beta.mcafee.com

HTTP/1.1 302 Object moved
Location: BetaMcAfee/Home.aspx

GET /BetaMcAfee/Home.aspx HTTP/1.1
Host: beta.mcafee.com

HTTP/1.1 302 Found
Location: /BetaMcAfee/Home.aspx?cookieCheck=true

GET /BetaMcAfee/Home.aspx?cookieCheck=true HTTP/1.1
Host: beta.mcafee.com

HTTP/1.1 302 Found
Location: http://beta.mcafee.com/betamcafee/BetaHome.aspx

@J0WI

J0WI commented Oct 6, 2016

Copy link
Copy Markdown
Contributor

That should be fine, because this are redirects to different locations, which are supporting HTTPS.

@J0WI

J0WI commented Oct 7, 2016

Copy link
Copy Markdown
Contributor

Thanks!

@J0WI
J0WI merged commit 15bb7e0 into EFForg:master Oct 7, 2016
@gloomy-ghost
gloomy-ghost deleted the gloomy-ghost-McAfee branch October 16, 2016 09:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants