Repository navigation
New ruleset for Board Game Arena. - #6975
Conversation
|
Thanks for the ruleset. Before we look at this in more detail, please note that we discourage wildcard targets. Instead, list each subdomain as a target. See the style guide for that and other information. |
|
Thanks. Please do the following. For the first three groups, add them to a comment at the top like you see here. Mark as Mark as Mark as
Add
Also:
|
|
This website has recently started doing its own HTTP -> HTTPS redirections. I'll hold off for now to see whether they enable HSTS soon. |
|
I assume you mean the HSTS preload list, such as we're discussing in #7126 . Even if they do add all of their domains to the preload list, it will take some time for them to propagate far enough for us to consider them invalid HTTPS Everywhere targets. I don't want to keep this pull request open indefinitely. The changes I asked for should be easy to do. Can you just do them, or else, can you enable "edits from maintainers" on this pull request and let me do them? |
|
I have made the suggested changes. Are these additional guidelines documented anywhere? I don't see them at https://www.eff.org/https-everywhere/rulesets nor https://github.com/EFForg/https-everywhere/blob/master/ruleset-style.md. I must admit that I feel like I'm trying to hit a moving target. |
|
The tests are failing because these I agree the documentation can be improved. We're discussing a new Also, we like to squash-and-merge pull requests, which means that we combine and rewrite your commits in your name. Are you okay with that for this and any other pull requests you submit to us? |
|
Squashed commits are fine by me. |
|
Please remove the |
|
Thanks, merged. |
No description provided.