Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

New ruleset for Board Game Arena. - #6975

Merged
jeremyn merged 8 commits into
EFForg:masterfrom
mavit:boardgamearena
Oct 24, 2016
Merged

jeremyn merged 8 commits into
EFForg:masterfrom
mavit:boardgamearena

Conversation

@mavit

@mavit mavit commented Sep 22, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@jeremyn

jeremyn commented Oct 5, 2016

Copy link
Copy Markdown
Contributor

Thanks for the ruleset. Before we look at this in more detail, please note that we discourage wildcard targets. Instead, list each subdomain as a target. See the style guide for that and other information.

@jeremyn

jeremyn commented Oct 5, 2016 •

Copy link
Copy Markdown
Contributor

Thanks. Please do the following. For the first three groups, add them to a comment at the top like you see here.

Mark as Mismatch:

Mark as Refused:

Mark as Timeout. You can list them as I've given below, you don't need to name them individually:

  • (.+)?doc.boardgamearena.com , example: en.doc.boardgamearena.com
  • (.+)?studio.boardgamearena.com , example: en.studio.boardgamearena.com

Add target, list each target individually:

Also:

  • Sort the subdomains. They should be grouped alphabetically starting at the top level domain at the right and reading left, with ^ and www moved to the top of their group. For example:
example.com
www.example.com
a.example.com
www.a.example.com
b.a.example.com
b.example.com
example.net
www.example.net
a.example.net
  • Remove the two "where the target came from" comments
  • Move securecookie between the targets and the rule

@jeremyn jeremyn self-assigned this Oct 5, 2016
@mavit

mavit commented Oct 21, 2016

Copy link
Copy Markdown
Contributor Author

This website has recently started doing its own HTTP -> HTTPS redirections. I'll hold off for now to see whether they enable HSTS soon.

@jeremyn

jeremyn commented Oct 21, 2016

Copy link
Copy Markdown
Contributor

I assume you mean the HSTS preload list, such as we're discussing in #7126 . Even if they do add all of their domains to the preload list, it will take some time for them to propagate far enough for us to consider them invalid HTTPS Everywhere targets.

I don't want to keep this pull request open indefinitely. The changes I asked for should be easy to do. Can you just do them, or else, can you enable "edits from maintainers" on this pull request and let me do them?

@mavit

mavit commented Oct 23, 2016

Copy link
Copy Markdown
Contributor Author

I have made the suggested changes.

Are these additional guidelines documented anywhere? I don't see them at https://www.eff.org/https-everywhere/rulesets nor https://github.com/EFForg/https-everywhere/blob/master/ruleset-style.md. I must admit that I feel like I'm trying to hit a moving target.

@jeremyn

jeremyn commented Oct 24, 2016

Copy link
Copy Markdown
Contributor

The tests are failing because these targets are invalid, specifically you can't put regexes in them like that. You need to list the targets out, which is what I meant by "list each target individually". On reread though this even confused me, so I've added some examples to the checklist that I hope make it more clear.

I agree the documentation can be improved. We're discussing a new CONTRIBUTING.md, please feel free to add any comments you like to the linked pull request. I also understand your worry about a moving target. What's in the checklist should be it, unless there is some major new problem.

Also, we like to squash-and-merge pull requests, which means that we combine and rewrite your commits in your name. Are you okay with that for this and any other pull requests you submit to us?

@mavit

mavit commented Oct 24, 2016

Copy link
Copy Markdown
Contributor Author

Squashed commits are fine by me.

@jeremyn

jeremyn commented Oct 24, 2016

Copy link
Copy Markdown
Contributor

Please remove the https:// from the URLs in the top comment so that they have the same format that you see here.

@jeremyn
jeremyn merged commit 68626eb into EFForg:master Oct 24, 2016
@jeremyn

jeremyn commented Oct 24, 2016

Copy link
Copy Markdown
Contributor

Thanks, merged.

@jeremyn jeremyn removed their assignment Oct 24, 2016
@mavit
mavit deleted the boardgamearena branch October 24, 2016 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants