Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update VMware.xml - #6971

Merged
jeremyn merged 2 commits into
EFForg:masterfrom
gloomy-ghost:gloomy-ghost-vmware
Sep 23, 2016
Merged

jeremyn merged 2 commits into
EFForg:masterfrom
gloomy-ghost:gloomy-ghost-vmware

Conversation

@gloomy-ghost

Copy link
Copy Markdown
Collaborator

Add exclusion for learn
Fix: #6875

Add exclusion for learn
Ref: EFForg#6875
@gloomy-ghost

Copy link
Copy Markdown
Collaborator Author

There is a bunch of subdomains... Google gives 400 when I use
site:vmware.com -site:buildweb.eng.vmware.com -site:code.vmware.com -site:cuny.horizon.vmware.com ....

It seems to be inevitable for losing some subdomains if we want to remove wildcard. Please let me know if temporary losing of subdomains is acceptable.

@jeremyn jeremyn self-assigned this Sep 22, 2016
@jeremyn

jeremyn commented Sep 22, 2016 •

Copy link
Copy Markdown
Contributor

I suggest keeping this pull request minimal to fix the reported problem with learn. If you want to do a bigger cleanup for VMware.xml -- please feel free! -- then do that in a separate pull request.

For this pull request:

  • Please change where learn appears in each case so that it's alphabetical. You can renumber the footnotes in the comment to keep them as 1/2/3/4 if you want.

Alphabetize
@jeremyn
jeremyn merged commit 342768f into EFForg:master Sep 23, 2016
@jeremyn

jeremyn commented Sep 23, 2016

Copy link
Copy Markdown
Contributor

Thanks, merged.

@jeremyn jeremyn removed their assignment Sep 23, 2016
@gloomy-ghost
gloomy-ghost deleted the gloomy-ghost-vmware branch November 15, 2016 07:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants