Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

nsICookieManager and OriginAttributes: fix issue #4241 - #6920

Closed
bakulf wants to merge 1 commit into
EFForg:masterfrom
bakulf:master
Closed

bakulf wants to merge 1 commit into
EFForg:masterfrom
bakulf:master

Conversation

@bakulf

@bakulf bakulf commented Sep 20, 2016

Copy link
Copy Markdown

No description provided.

@jeremyn

jeremyn commented Sep 20, 2016

Copy link
Copy Markdown
Contributor

@Hainish Can you review this one, please?

@Hainish

Hainish commented Sep 20, 2016

Copy link
Copy Markdown
Member

Reviewing now

@Hainish

Hainish commented Sep 21, 2016

Copy link
Copy Markdown
Member

@bakulf currently a large portion of our users are on Tor Browser, the current version of which is derived from Firefox ESR (45.4.0esr). Tor Browser >= 6.0 is using Firefox ESR >= 45.1.1esr. It looks like the changes here have not been backported to ESR, is that correct?

@Hainish

Hainish commented Sep 21, 2016

Copy link
Copy Markdown
Member

I believe this PR would break for our TB users.

@bakulf

bakulf commented Sep 21, 2016

Copy link
Copy Markdown
Author

You are right. If we want to be compatible with ESR, we cannot land this patch.
In this case, I suggest to keep the code as it is.
Alternatively we could add checks as: if ("originAttributes" in cookie) { cm.add(..., {});

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants