Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

[Nemzeti Adó- és Vámhivatal] Add ruleset - #6888

Merged
J0WI merged 3 commits into
EFForg:masterfrom
mszabo-wikia:nav-hu
Mar 12, 2017
Merged

J0WI merged 3 commits into
EFForg:masterfrom
mszabo-wikia:nav-hu

Conversation

@mszabo-wikia

Copy link
Copy Markdown
Contributor

Website of the National Tax and Customs Administration of Hungary

@jeremyn

jeremyn commented Oct 5, 2016 •

Copy link
Copy Markdown
Contributor

Thanks for your contribution. Please:

Add targets:

Also:

  • Sort the targets. They should be alphabetical starting from the top-level domain at the right, reading left, with ^ and www at the top. So in this case it should be nav.gov.hu, then www.nav.gov.hu, then the rest in alphabetical order.
  • Delete this cert comment.
  • Instead of this Nonfunctional subdomains: heading, write the specific problem, which here is Different HTTP/HTTPS content: 403, HTTPS only: .

Finally, we like to squash-and-merge commits, which means we rewrite your commits in your name. Are you okay with that for this pull request and any other pull requests you submit to us?

@jeremyn

jeremyn commented Nov 30, 2016

Copy link
Copy Markdown
Contributor

@tk-999 Are you still interested in working on this?

@jeremyn

jeremyn commented Dec 19, 2016

Copy link
Copy Markdown
Contributor

@tk-999 I've pushed an update to your branch making the changes in the checklist in #6888 (comment) and also some others. Do the changes look okay to you?

@jeremyn

jeremyn commented Jan 25, 2017

Copy link
Copy Markdown
Contributor

@tk-999 Can you please review the changes I made?

@jeremyn jeremyn closed this Mar 9, 2017
@jeremyn jeremyn reopened this Mar 9, 2017
@jeremyn

jeremyn commented Mar 9, 2017

Copy link
Copy Markdown
Contributor

Hi @tk-999, can you please review the changes? It should be quick to do. Otherwise I'm going to close this pull request. Thanks.

@mszabo-wikia

Copy link
Copy Markdown
Contributor Author

@jeremyn Sorry, the previous notification seems to have disappeared among my other notifs so I didn't see that one.

Changes look great, thanks for taking the time for implementing them, and sorry about the delay!

@jeremyn

jeremyn commented Mar 10, 2017

Copy link
Copy Markdown
Contributor

That's fine @tk-999, thanks for letting me know.

@gloomy-ghost @J0WI Can one of you review this please? Please use regular merge instead of squash-and-merge because there are multiple contributors (me and @tk-999).

@jeremyn jeremyn removed their assignment Mar 10, 2017
@J0WI
J0WI merged commit cf601e5 into EFForg:master Mar 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants