Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

add rule for Everydayfeminism.com - #6782

Merged
jeremyn merged 1 commit into
masterfrom
unknown repository
Sep 7, 2016
Merged

jeremyn merged 1 commit into
masterfrom
unknown repository

Conversation

@Mikaela

@Mikaela Mikaela commented Sep 6, 2016

Copy link
Copy Markdown
Contributor

I wasn't able to run the tests as the depedency installing script doesn't understand Arch Linux or pacman package manager, but this rule seems to work without breaking anything when added to Firefox custom rule directory. I use some other extensions though (PrivacyBadger could affect the tests), but I hope everything is done properly and your tests will raise the issues if there are any before any harm happens.

@jeremyn

jeremyn commented Sep 6, 2016

Copy link
Copy Markdown
Contributor

Thanks, this looks fine. For development we support Debian/Ubuntu, RedHat/Fedora, and Mac. If you want to add Arch support, that would be welcome and would probably not be too difficult to do.

We like to squash-and-merge commits, which means rewriting your commit in your name. Is that all right?

@jeremyn jeremyn self-assigned this Sep 6, 2016
@Mikaela

Mikaela commented Sep 7, 2016

Copy link
Copy Markdown
Contributor Author

If you want to add Arch support, that would be welcome and would probably not be too difficult to do.

I fear it's outside my abilities/resources for now.

We like to squash-and-merge commits, which means rewriting your commit in your name. Is that all right?

It's OK as long as you are aware that it erases the GPG signature and that is fine for you.

@jeremyn
jeremyn merged commit 0022a03 into EFForg:master Sep 7, 2016
@jeremyn

jeremyn commented Sep 7, 2016

Copy link
Copy Markdown
Contributor

That's fine, thanks. Merged.

@jeremyn jeremyn removed their assignment Sep 10, 2016
@Mikaela
Mikaela deleted the Everydayfeminism.com branch October 9, 2016 06:39
@Mikaela

Mikaela commented Oct 11, 2016

Copy link
Copy Markdown
Contributor Author

Why would a rule work with Firefox desktop (50.0b5), but not with Firefox Beta for Android (50.0b4)? Both browsers say to be using HTTPS Everywhere 5.2.5 and I see the rule in question https://github.com/EFForg/https-everywhere/blob/5.2.5/src/chrome/content/rules/Everydayfeminism.com.xml under the tag 5.2.5. The site also doesn't have separate mobile site that I can see (I don't know anywhere deeper to look than the address bar though).

I wondered this on Sunday at #https-everywhere on irc.oftc.net which seems quite silent. I hope you do read at least GitHub if not IRC or there was some event preventing IRC from seeing.

@jeremyn

jeremyn commented Oct 11, 2016

Copy link
Copy Markdown
Contributor

I don't follow HTTPS Everywhere IRC channels. The best place to report problems is GitHub.

I can confirm the problem you're seeing, that is, http://everydayfeminism.com doesn't get rewritten to HTTPS on Firefox for Android even with HTTPS Everywhere 5.2.5, but it does get rewritten in desktop Firefox. I don't know why. Could you please submit a new issue for this problem?

@Mikaela

Mikaela commented Oct 11, 2016

Copy link
Copy Markdown
Contributor Author

Moved to #7317 .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants