Repository navigation
add more hosts to swissgov.xml - #6771
Conversation
|
I think the fetch errors here are false positives. |
|
I get |
|
I commented the host out for now, so test are passing. |
|
ping @jeremyn for a review |
|
Checklist for Note as Add Also:
Checklist for
Checklist for
Checklist for Top comment changes, read this as "URL, what I got, what comment says":
Add
Also:
|
|
I addressed all other points. |
|
|
|
I've added |
|
I recommend splitting the three approved rulesets into a new pull request, and then make new pull requests as you split stuff off of |
|
That would have been nice to know before you started to review... |
|
It's not easy to just split this now in different PRs, because of the all the references. Can we just merge the updates on |
|
I think it's okay to have unreturned references from the other files to I'm not sure what to suggest for the
|
|
@jeremyn I rebased this branch and reorganized the comments. Please review with the following notes in mind:
|
|
@jeremyn I would really like to continue here. Can you manage to spend some attention on this again? |
|
I've updated the checklist through the 4ddaa99, and only through the top comment. Please get rid of the nested |
|
Thanks for the feedback.
Well, this host has both issues, but the chain is just a minor thing.
Only
I think it's much easier to maintain this way. You can find each host in the breadcrumb in the same structure. |
|
I've updated the checklist through b6f52f7 and have otherwise finished reviewing. |
|
I'm fine with redirecting |
|
I've updated the checklist through d82b291. In your last comment, just to confirm, do you mean that you are okay with the way you have it now, where we rewrite http://rab-asr.ch to https://rab-asr.ch even though the site itself redirects http://rab-asr.ch to https://www.rab-asr.ch ? |
|
Yes, both have exactly the same content. Let's keep it simple. |
|
Merged. |
|
Thanks! |
No description provided.