Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update Sina.xml - #6765

Merged
J0WI merged 4 commits into
EFForg:masterfrom
gloomy-ghost:gloomy-ghost-patch-1
Sep 17, 2016
Merged

J0WI merged 4 commits into
EFForg:masterfrom
gloomy-ghost:gloomy-ghost-patch-1

Conversation

@gloomy-ghost

Copy link
Copy Markdown
Collaborator

Mixed Content: The page at 'https://login.sina.com.cn/crossdomain2.php?action=login&entry=weibo...' was loaded over HTTPS, but requested an insecure script 'http://i.sso.sina.com.cn/js/ssologin.js'.

Mixed Content: The page at 'https://login.sina.com.cn/crossdomain2.php?action=login&entry=weibo...' was loaded over HTTPS, but requested an insecure script 'http://i.sso.sina.com.cn/js/ssologin.js'.
@gloomy-ghost gloomy-ghost mentioned this pull request Sep 6, 2016
@J0WI

J0WI commented Sep 8, 2016

Copy link
Copy Markdown
Contributor

This requires a valid test url.
Please also add a short comment in the rule file, why this exclusion is needed.

Comment thread src/chrome/content/rules/Sina.xml Outdated
<target host="help.sina.com.cn" />
<target host="licaishi.sina.com.cn" />
<target host="login.sina.com.cn" />
<!-- The page at 'crossdomain2.php' is loaded over HTTPS, but requests an insecure script 'http://i.sso.sina.com.cn/js/ssologin.js'. -->

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only happens when the parameter ?action=login is present.

@gloomy-ghost

Copy link
Copy Markdown
Collaborator Author

Done

@ivysrono

Copy link
Copy Markdown
Contributor

+1

@J0WI
J0WI merged commit 9b5c36c into EFForg:master Sep 17, 2016
@gloomy-ghost
gloomy-ghost deleted the gloomy-ghost-patch-1 branch September 21, 2016 05:49
@gloomy-ghost

Copy link
Copy Markdown
Collaborator Author

@J0WI I think this PR has fixed #5106 #6227

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants