Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Delete 23zw.com.xml - #6610

Merged
J0WI merged 1 commit into
EFForg:masterfrom
ivysrono:patch-196
Sep 10, 2016
Merged

J0WI merged 1 commit into
EFForg:masterfrom
ivysrono:patch-196

Conversation

@ivysrono

@ivysrono ivysrono commented Aug 26, 2016 •

Copy link
Copy Markdown
Contributor

The host owner has removed https……

The host owner has remove https……
@J0WI

J0WI commented Aug 26, 2016

Copy link
Copy Markdown
Contributor

We still have no clear guide line if such rules should be deleted or disabled.
What do you mean? @fuglede @jeremyn

@jeremyn

jeremyn commented Aug 26, 2016

Copy link
Copy Markdown
Contributor

I think we should delete. It's simpler. Also we wouldn't create a rule for a site that doesn't have HTTPS, so why keep a rule around for a site without it?

@fuglede

fuglede commented Aug 26, 2016

Copy link
Copy Markdown
Contributor

How are we doing at keeping inactive rulesets out of memory? If that is no longer an issue, I would be all for keeping the rules, to provide history, and to let new contributors immediately know if the ruleset that they are currently working on has seen work earlier. Otherwise, I have no strong opinion on it.

@Hainish

Hainish commented Aug 27, 2016 •

Copy link
Copy Markdown
Member

Disabled rules are still kept in memory, and in fact still "enableable" from the browser. For instance, direct your browser at http://static.atv.hu/, which is part of https://github.com/EFForg/https-everywhere/blob/master/src/chrome/content/rules/ATV.hu.xml. Even though DNS doesn't even resolve for this site, you'll still see you can manually enable the rule from the drop-down menu.

So disabling a rule is useful if, for instance, some site has broken its HTTPS implementation, but may fix it in the future. It lets users turn it back on once they do fix it, before we make a new release. Also, if a site is only partially broken, disabling is preferable. We don't want to impede functionality for users, but if some users are okay with partial site functionality and want the security regardless, they can manually enable t hat rule. For sites that look like they've disappeared completely, we probably want to completely delete the ruleset, so that it isn't taking up space in memory.

@ivysrono

Copy link
Copy Markdown
Contributor Author

BTW, should we delete the sites that force https by server?
For instance:
ImQuQu.com.xml
https://imququ.com/post/moving-to-https-asap.html

@jeremyn

jeremyn commented Aug 27, 2016

Copy link
Copy Markdown
Contributor

@renyouguo Sites that redirect from HTTP to HTTPS are still valid for HTTPS Everywhere, see here.

@jeremyn

jeremyn commented Aug 27, 2016

Copy link
Copy Markdown
Contributor

@fuglede Contributors making a new ruleset should already be searching the repository in GitHub first to make sure there isn't already an existing ruleset or pending pull request that does what they want. I admit we don't document this well.

@fuglede

fuglede commented Aug 27, 2016

Copy link
Copy Markdown
Contributor

@jeremym: That's my point: They will have no chance to find that existing ruleset if it has been deleted.

@jeremyn

jeremyn commented Aug 27, 2016 •

Copy link
Copy Markdown
Contributor

@fuglede I mean searching the repository in GitHub, not just the code. For example, if you search the repository for pan.baidu.com, you get this, including a result for pull request #4577 that was a pure deletion.

Edit: (you meant to @ jeremyn, not ...m.)

@fuglede

fuglede commented Aug 28, 2016 •

Copy link
Copy Markdown
Contributor

@jeremyn: Fair enough, I suppose that would catch some of them. I'm not sure people actually do that; at least we have plenty of dupes among issue reports. A slightly more esoteric point would be that this has no effect on those rulesets that have not been produced through GitHub PRs and issues; for example, there are 5134 closed and open PRs, but 21493 rulesets, so there must be a non-trivial mismatch.

@ivysrono

ivysrono commented Aug 28, 2016 •

Copy link
Copy Markdown
Contributor Author

Hi, there are 10+ PRs waiting your check : https://github.com/EFForg/https-everywhere/pulls/renyouguo

@ivysrono

ivysrono commented Sep 8, 2016

Copy link
Copy Markdown
Contributor Author

@J0WI @jeremyn @fuglede @Hainish What's your decision?

@jeremyn

jeremyn commented Sep 8, 2016

Copy link
Copy Markdown
Contributor

If we're voting, I vote to delete it.

@J0WI
J0WI merged commit 3892d94 into EFForg:master Sep 10, 2016
@fuglede

fuglede commented Sep 11, 2016

Copy link
Copy Markdown
Contributor

@Hainish: What I was wondering was more if we had been able to reduce the memory usage of the disabled ones to something below what we require from the active ones, cf. e.g. the remark in #1775 (comment) (and the general discussion in that thread).

@Hainish

Hainish commented Sep 13, 2016

Copy link
Copy Markdown
Member

@fuglede I don't think we have reduced memory usage for inactive/disabled rules.

When a user navigates to a target of a disabled ruleset, we currently present the user with the option to re-enable the ruleset. In order for this to work, we have to at least have the ruleset list of targets loaded into memory. One optimization could be that upon clicking to re-enable, all previously extraneous information that is now required (secure cookies, exceptions, the rules themselves) can be retrieved from the disk.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants