Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Komoona.com update - #6602

Merged
gloomy-ghost merged 2 commits into
EFForg:masterfrom
numismatika:KMC
Jul 28, 2017
Merged

gloomy-ghost merged 2 commits into
EFForg:masterfrom
numismatika:KMC

Conversation

@numismatika

Copy link
Copy Markdown
Contributor
  • remove wildcard
  • cdn now serves a valid cert
  • add some more subdomains

<target host="w.komoona.com" />
<target host="www.komoona.com" />

<exclusion pattern="^http://www\.komoona\.com/+(?!favicon\.ico|new/css/|new/images/)" />

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try ^http://www\.komoona\.com/(?!favicon\.ico|new/css/|new/images/)


<test url="http://www.komoona.com/favicon.ico" />
<test url="http://www.komoona.com/new/css/" />
<test url="http://www.komoona.com/new/images/" />

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These test urls are repeated, could you remove them?

<test url="http://www.komoona.com/favicon.ico" />
<test url="http://www.komoona.com/new/css/" />
<test url="http://www.komoona.com/new/images/" />

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then you need to add 3 more test urls that match the exclusion.

FYI, only https://www.komoona.com redirects to http. The other pages have a font is blocked but it doesn't look broken. I am not a official reviewer, but I would suggest just exclude ^http://www\.komoona\.com/$

Numismatika added 2 commits November 19, 2016 12:28
- remove wildcard
- cdn now serves a valid cert
- add some more subdomains
- add test urls
@J0WI

J0WI commented Jul 28, 2017

Copy link
Copy Markdown
Contributor

ping @gloomy-ghost

@gloomy-ghost
gloomy-ghost merged commit c54a62c into EFForg:master Jul 28, 2017
@numismatika
numismatika deleted the KMC branch July 29, 2017 05:55
luciancor pushed a commit to luciancor/https-everywhere that referenced this pull request Aug 24, 2017
* Komoona.com:
- remove wildcard
- cdn now serves a valid cert
- add some more subdomains
- add test urls

* komoona
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants