This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
Komoona.com update - #6602
Merged
Merged
Komoona.com update#6602
Conversation
numismatika
commented
Aug 25, 2016
Contributor
- remove wildcard
- cdn now serves a valid cert
- add some more subdomains
| <target host="w.komoona.com" /> | ||
| <target host="www.komoona.com" /> | ||
|
|
||
| <exclusion pattern="^http://www\.komoona\.com/+(?!favicon\.ico|new/css/|new/images/)" /> |
Collaborator
There was a problem hiding this comment.
Try ^http://www\.komoona\.com/(?!favicon\.ico|new/css/|new/images/)
gloomy-ghost
suggested changes
Sep 24, 2016
|
|
||
| <test url="http://www.komoona.com/favicon.ico" /> | ||
| <test url="http://www.komoona.com/new/css/" /> | ||
| <test url="http://www.komoona.com/new/images/" /> |
Collaborator
There was a problem hiding this comment.
These test urls are repeated, could you remove them?
| <test url="http://www.komoona.com/favicon.ico" /> | ||
| <test url="http://www.komoona.com/new/css/" /> | ||
| <test url="http://www.komoona.com/new/images/" /> | ||
|
|
Collaborator
There was a problem hiding this comment.
Then you need to add 3 more test urls that match the exclusion.
FYI, only https://www.komoona.com redirects to http. The other pages have a font is blocked but it doesn't look broken. I am not a official reviewer, but I would suggest just exclude ^http://www\.komoona\.com/$
added 2 commits
November 19, 2016 12:28
- remove wildcard - cdn now serves a valid cert - add some more subdomains - add test urls
Contributor
|
ping @gloomy-ghost |
luciancor
pushed a commit
to luciancor/https-everywhere
that referenced
this pull request
Aug 24, 2017
* Komoona.com: - remove wildcard - cdn now serves a valid cert - add some more subdomains - add test urls * komoona
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.