Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update and rename Samsung.xml to Samsung.com.xml - #6485

Merged
J0WI merged 51 commits into
EFForg:masterfrom
ivysrono:patch-175
Aug 25, 2016
Merged

J0WI merged 51 commits into
EFForg:masterfrom
ivysrono:patch-175

Conversation

@ivysrono

Copy link
Copy Markdown
Contributor

No description provided.

@ivysrono ivysrono mentioned this pull request Aug 20, 2016
<exclusion pattern="^http://m\.allshareplay\.com/$" />
<test url="http://m.allshareplay.com/" />

<rule from="^http://(?:www\.)?allshareplay\.com/$"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only needed for ^allshareplay.com/$, www works server side https. Please also document why this is needed (403).

@ivysrono

Copy link
Copy Markdown
Contributor Author

@J0WI Thank you very much.

<exclusion pattern="^http://m\.allshareplay\.com/$" />
<test url="http://m.allshareplay.com/" />

<rule from="^http://allshareplay\.com/$"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also document the 403 here.

@J0WI

J0WI commented Aug 25, 2016

Copy link
Copy Markdown
Contributor

Just a few minor issues left, see inline comments.

@J0WI

J0WI commented Aug 25, 2016

Copy link
Copy Markdown
Contributor

LGTM, thanks for this huge contribution!

@J0WI
J0WI merged commit 0b26f38 into EFForg:master Aug 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants