Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Separate out travis tests, one per different component to test. - #6220

Merged
Hainish merged 4 commits into
EFForg:masterfrom
Hainish:separate-travis-tests
Aug 16, 2016
Merged

Hainish merged 4 commits into
EFForg:masterfrom
Hainish:separate-travis-tests

Conversation

@Hainish

@Hainish Hainish commented Aug 11, 2016

Copy link
Copy Markdown
Member

No description provided.

@Hainish
Hainish force-pushed the separate-travis-tests branch 2 times, most recently from d08b21b to 68f0160 Compare August 11, 2016 23:18
@Hainish
Hainish force-pushed the separate-travis-tests branch from 68f0160 to 96e962f Compare August 12, 2016 00:23
…nning and if it's necessary to test at all, given what files are changed
@Hainish
Hainish force-pushed the separate-travis-tests branch from 66b1671 to d4cfeb0 Compare August 12, 2016 01:38
@Hainish Hainish changed the title [WIP] Separate out travis tests, one per different component to test. Separate out travis tests, one per different component to test. Aug 12, 2016
@Hainish

Hainish commented Aug 12, 2016

Copy link
Copy Markdown
Member Author

@jsha @cooperq this is ready for review. If you want to review this in person with me lmk, there's a lot here

@Hainish

Hainish commented Aug 12, 2016

Copy link
Copy Markdown
Member Author

As you can see, there will now be 6 distinct builds for each PR:

https://travis-ci.org/EFForg/https-everywhere/builds/151690169

I've added one additional test for the firefox-dev (Firefox Developer Edition), which should show us if problems start arising in future versions and give us time to fix it.

The travis.yml file now references test/travis.sh, which has some conditional logic around when tests should be run based on what environment we're in. I've also placed the docker build within this script, so we don't build the docker image in environments where we won't run any tests (for instance if it's a ruleset change and not a core code change and we're in the TEST=firefox env, we don't actually need any tests run, so don't even build the docker image). This is better than, say, including a docker build as a before_script in travis because then each of the 6 envs would build the image (which includes a 1.3G download from dockerhub) no matter if any tests had to be run with that image or not.

I expect this will make travis builds faster, since all the tests can run in parallel now. It will also not run tests which are unnecessary for the type of PR (ruleset or core code). Finally, for ruleset maintainers and core maintainers alike, it will now be a little clearer on the travis build page what component of the build is failing, without having to dig into the build logs.

@Hainish

Hainish commented Aug 12, 2016

Copy link
Copy Markdown
Member Author

@J0WI just tagging you so you're aware how the breakdown of travis tests will soon look.

Comment thread test/fetch.sh Outdated

RULETESTFOLDER="test/rules"

# Make a list of all changed rulesets, but exclude those

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is out of date; we're no longer making this list here.

@Hainish

Hainish commented Aug 15, 2016

Copy link
Copy Markdown
Member Author

Ready for review again!

@cooperq

cooperq commented Aug 16, 2016

Copy link
Copy Markdown
Contributor

lgtm

@cooperq

cooperq commented Aug 16, 2016

Copy link
Copy Markdown
Contributor

Merge when ready.

@Hainish
Hainish merged commit afb7f8f into EFForg:master Aug 16, 2016
@Hainish
Hainish deleted the separate-travis-tests branch February 23, 2018 01:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants