Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Create kf5.com.xml - #5788

Merged
J0WI merged 4 commits into
EFForg:masterfrom
ivysrono:patch-168
Jul 26, 2016
Merged

J0WI merged 4 commits into
EFForg:masterfrom
ivysrono:patch-168

Conversation

@ivysrono

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/chrome/content/rules/kf5.com.xml Outdated
@@ -0,0 +1,25 @@
<!--
kf5.com is an open site, so there are lots of *.kf5.com sites, which are too much to list all of them.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that they all support https, so a wildcard with exclusions would make sense here.
The current targets can be kept as test urls.

Comment thread src/chrome/content/rules/kf5.com.xml Outdated

<target host="*.kf5.com" />

<exclusion pattern="^http://(agents|d)\.kf5\.com/(.*)" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The (.*) on the end is not needed, the pattern will match anyway and is much simpler.

@J0WI
J0WI merged commit e15406d into EFForg:master Jul 26, 2016
@luixxiul luixxiul mentioned this pull request Jul 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants