This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
[AOL] Removed exclusion for nonexistent URL, added... #4495
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel a bit uncomfortable with that, since it was added by the AOL team itself (see d6df8ba).
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@J0WI Right now, it appears that the URL http://my.screenname.aol.com/_cqr/logout/ leads to a 404 response error page with a message about "They page you are looking for might have been removed." This error page is encountered regardless of whether the URL is accessed via HTTP or HTTPS. It is possible that the URL was functional in the past and that the URLs for logging out of the AOL service have changed over time. (It might be possible for the URL to become functional in the future, but that does not seem to be necessarily likely.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand it, the specified exclusion pattern defines just the root of URLs to be excluded. If you do an HTTP Trace on a logout of www.aol.com, it will actually invoke http://my.screenname.aol.com/_cqr/logout/mcLogout.psp with some query parameters. I don't work on the application at AOL anymore, but I did confirm with the developers that this is still needed. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, that is true too. account.login.aol.com moved to i.aol.com.