Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Add ruleset for www.parkerpen.com - #4303

Merged
J0WI merged 2 commits into
EFForg:masterfrom
Liudvikam:Parker
Aug 23, 2016
Merged

J0WI merged 2 commits into
EFForg:masterfrom
Liudvikam:Parker

Conversation

@Liudvikam

Copy link
Copy Markdown
Contributor

No description provided.

@J0WI

J0WI commented Mar 9, 2016

Copy link
Copy Markdown
Contributor

I also found origin.parkerpen.com and mgmt.parkerpen.com (mismatch).
Please also comment the mismatch on ^parkerpen.com.

<target host="www.parkerpen.com" />
<target host="assets.parkerpen.com" />

<rule from="^https?://(www\.)?parkerpen\.com/"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't touch https

@Liudvikam

Copy link
Copy Markdown
Contributor Author

I also found origin.parkerpen.com and mgmt.parkerpen.com (mismatch).

Comment added. Also, mgmt.parkerpen.com isn't actually a mismatch, so I added it to the ruleset.

Please also comment the mismatch on ^parkerpen.com.

Done.

We don't touch https

I did that because if someone visits https://parkerpen.com, they get a cert error. The redirect fixes that. Should I still remove it?

@fuglede

fuglede commented Mar 11, 2016

Copy link
Copy Markdown
Contributor

Quite a few rules actually use the https?trick,

https-everywhere/rules$ grep 'from="^https?' * | wc -l
79

but yeah, it can lead to some undesired and unnecessary maintenance.

This was referenced Mar 17, 2016
@Hainish Hainish added the top-1m label Aug 19, 2016
@J0WI

J0WI commented Aug 23, 2016

Copy link
Copy Markdown
Contributor

I'll merge this now after retesting, but we should clean the https? rules up.

@J0WI J0WI closed this Aug 23, 2016
@J0WI J0WI reopened this Aug 23, 2016
@J0WI
J0WI merged commit 30bd476 into EFForg:master Aug 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants