Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Create bewelcome.org.xml - #4261

Closed
simison wants to merge 1 commit into
EFForg:masterfrom
simison:patch-1
Closed

simison wants to merge 1 commit into
EFForg:masterfrom
simison:patch-1

Conversation

@simison

@simison simison commented Mar 4, 2016

Copy link
Copy Markdown

@fuglede

fuglede commented Mar 18, 2016

Copy link
Copy Markdown
Contributor

Thanks for the PR. As you might have seen, Travis complains about the lack of tests in this ruleset. You can refer to this part of the documentation for more information on ruleset testing.

@simison

simison commented Mar 21, 2016

Copy link
Copy Markdown
Author

Yep, noticed, but sadly I don't have time for that right now.

I asked from the BW community for some help though: http://www.bewelcome.org/forums/s13127/#post78001 (link requires login)

posted 2016/03/07 03:26
Ah, my code request to HTTPSEverywhere can't go trough due missing tests.

If you're tech savvy, feel free to add them to my repository and I'll add them, or send a new PR to HTTPS Everywhere. I unfortunately don't have time for this now.

@simison

simison commented Mar 21, 2016

Copy link
Copy Markdown
Author

^ That said, feel free to close this, since frankly I don't think nobody would step up with tests. I can come over and re-open if someone else decides to work on this.

I wrote them and asked BW to switch to https, but nothing; BeWelcome/rox#13

@fuglede

fuglede commented Mar 21, 2016

Copy link
Copy Markdown
Contributor

Thanks for getting back on this. In this case, cooking up the tests really boils down to coming up with all the relevant subdomains of the site.

@simison

simison commented Apr 10, 2016

Copy link
Copy Markdown
Author

Closing, follow ups @ #4587

@simison simison closed this Apr 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants