Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Donate to eff continued - #4212

Merged
cooperq merged 3 commits into
EFForg:masterfrom
Hainish:donate-to-eff-continued
Feb 23, 2016
Merged

cooperq merged 3 commits into
EFForg:masterfrom
Hainish:donate-to-eff-continued

Conversation

@Hainish

@Hainish Hainish commented Feb 23, 2016

Copy link
Copy Markdown
Member

No description provided.

Comment thread chromium/popup.html Outdated

<footer>
<a id="aboutTitle" href="https://www.eff.org/https-everywhere" target="_blank" i18n="about_title">blah</a>
<a id="aboutTitle" href="https://www.eff.org/https-everywhere" target="_blank" i18n="about_title">blah</a><br><br>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either leave this blank or fill in the default English value, rather than using "blah"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good point - I was just copying from the previously committed template.

@Hainish
Hainish force-pushed the donate-to-eff-continued branch from 0c95b8b to c51339c Compare February 23, 2016 20:01
@Hainish

Hainish commented Feb 23, 2016

Copy link
Copy Markdown
Member Author

Ready for review again @jsha

@cooperq

cooperq commented Feb 23, 2016

Copy link
Copy Markdown
Contributor

LGTM, ready to commit as soon as tests pass

cooperq added a commit that referenced this pull request Feb 23, 2016
@cooperq
cooperq merged commit a5b1712 into EFForg:master Feb 23, 2016
@jsha

jsha commented Feb 23, 2016

Copy link
Copy Markdown
Member

LGTM

@Hainish
Hainish deleted the donate-to-eff-continued branch February 24, 2016 01:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants