Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Add TikTok.com.xml - #19763

Merged
zoracon merged 2 commits into
EFForg:masterfrom
J0WI:tiktok
Nov 16, 2020
Merged

zoracon merged 2 commits into
EFForg:masterfrom
J0WI:tiktok

Conversation

@J0WI

@J0WI J0WI commented Nov 3, 2020

Copy link
Copy Markdown
Contributor

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring existing code
  • New Ruleset
  • Existing Ruleset

For Rulesets: Testing

  • Travis CI completed without errors (triggered upon pull request)

Comment thread src/chrome/content/rules/TikTok.com.xml Resolved
Comment thread src/chrome/content/rules/TikTok.com.xml Resolved
Comment thread src/chrome/content/rules/TikTok.com.xml Resolved
<target host="vt.tiktok.com" />

<!-- CDNs: -->
<target host="*.tiktokcdn.com" />

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to add a "real" test URL, with some content. What do you think?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to find persistent resources.

@Bisaloo

Bisaloo commented Nov 7, 2020

Copy link
Copy Markdown
Collaborator

Nevermind, you can disregard my comments relating to the main domain since it's apparently preloaded

@zoracon
zoracon merged commit 0242bd1 into EFForg:master Nov 16, 2020
@J0WI
J0WI deleted the tiktok branch November 16, 2020 12:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants