Repository navigation
Update CONTRIBUTING.md - #19638
Update CONTRIBUTING.md#19638zoracon wants to merge 2 commits into
Conversation
Update Nonfunctional Hosts Standard We have this in generated rules with make-trivial-rule script. It should be reflected in the Docs
|
@zoracon Let's change |
|
Also, is there evidence that this script is still used by people? Maybe we can completely remove it? |
@pipboy96 I am not sure who uses this and who doesn't. I am going to research the background on why this comment for hosts was structured this way. There's a lot of discussion from a few years ago concerning this topic. I want to decide on a simplistic format going forward. So my question is the format in |
|
To add, we also reference the Which being actively experimented with at the moment. |
|
The style in make-trivial-rule was being discussed in #6868 and the agreement (tagged master list) was made by a number of contributors. However, I agree with @pipboy96 that the style in the documentation (grouped list) and its variants are more commonly seen. Personally, I prefer the style in the current documentation. I believe the grouped list styles gained its popularity after the agreement is made. There was a time many contributors created their own bots for automatic generation of rulesets (#7691), and the grouped list styles turned out to be easier to parsers and formatters (e.g. #6912 (comment)) |
|
Thank you for the background @cschanaj. I am inclined to go with the previous consensus instead of going down that path again. The conversation seemed to have come to a good middle ground between the styles. I know the more verbose categorization seems to be dominant, but going forward would like to create a script that can easily parse this out and enforce this style. |
Revert doc on nonfunctional hosts but adjust spacing
| www.e.glavbukh.ru | ||
| Time out: | ||
| psd.glavbukh.ru | ||
| str.glavbukh.ru |
There was a problem hiding this comment.
Should we use an example domain or a domain we control for this?
There was a problem hiding this comment.
We can. I can adjust to reflect that or you can.
|
Merged in related PR, closing this one out |
Update Nonfunctional Hosts Standard
We have this in generated rules with make-trivial-rule script. It should be reflected in the Docs
Related: #14936