This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
Change Naming Convention - Block/Allow Listing for Clarity and Inclusion #19571
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3914d1d
Change naming convention of allow listing
zoracon 01c77f0
Remove cache files that snuck in
zoracon 98ae9d8
Remove package.json generated file that also snuck in
zoracon 5bf9687
Update docs/es/faq.md
zoracon ef08780
Amend Spanish Translation
zoracon d377218
Merge branch 'refactor/renaming-listing' of github.com:zoracon/https-…
zoracon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this question in the FAQ is misleading on how HTTPS Everywhere works. It is also inconsistent with the terminology we use. I believe this question would be better rephrased to avoid confusion.
HTTPS Everywhere use a collection of peer-reviewed rulesets to upgrade insecure HTTP connections to HTTPS. We also use the terminology "Add a rule for this site" on the extension user interface, our users "Enable"/ "Disable" rules with checkbox as needed.
Would something like
Why use bundled rulesets to upgrade insecure connections to HTTPS?better?P.S. I am not a native English speaker, so please forgive me if I am asking a weird question.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest
"Why not just redirect all websites by default?""Why not redirect every possible website?". The simplest wording possible is often the best one.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can change the wording, just have to coordinate a small effort to get the translation. I can schedule that into the next round of documentation updates. Wanted to focus on this renaming portion first. I will note this in the documentation items that need to be done.
Thank you both so much for reviewing with great care and compassion.